-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gzip serialization #3662
Conversation
Benchmarks have been migrated to the |
xref #3438 |
I'm sure I saw this issue at some point, but failed to review it prior to this PR. Would you like me to repackage this into the format discussed there? (i.e. |
No, just wanted to make sure there was reference to the other discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a minor qualm and a major qualm. What should this function be named?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. sorry about the delay this must have gotten lost in my inbox
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Automerge cancelled: A status check is failing. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Automerge cancelled: A status check is failing. |
Ah, the CLA doesn't like the email address that cf706f4 is associated with. I'll rebase and force-push to appease it. |
43d7bad
to
a0fa341
Compare
For comparison with #3655. Observed benchmark results, running locally: