Performance improvements in cirq interop #1054
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
reviewed
Jun 6, 2024
| @@ -99,6 +100,10 @@ def total_bits(self) -> int: | |||
|
|
|||
| This is the product of bitsize and each of the dimensions in `shape`. | |||
| """ | |||
| return self._total_bits | |||
|
|
|||
| @cached_property | |||
There was a problem hiding this comment.
just use cached method on the original method?
There was a problem hiding this comment.
functools doesn't seem to have a cached_method and I didn't want to add another dependency. using just cache would require computing hash of the class itself which would again be slow.
mpharrigan
reviewed
Jun 6, 2024
| @@ -157,7 +157,7 @@ def decompose_zero_selection( | |||
| ctrl=ctrl, junk=junk, target=and_target | |||
| ) | |||
| yield multi_controlled_and | |||
| yield self._load_nth_data(zero_indx, lambda q: CNOT().on(and_target, q), **target_regs) | |||
| yield self._load_nth_data(zero_indx, lambda q: cirq.CNOT(and_target, q), **target_regs) | |||
There was a problem hiding this comment.
use qualtran CNOT so that it can immediately unwrap from CirqGateAsBloq without doing any logic?
There was a problem hiding this comment.
Using qualtran CNOT is slower because CNOT in Qualtran is not a GateWithRegisters. So the cirq construction wraps it in a BloqAsCirqGate; which ends up being slow. See the first profiling picture in my linked comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low hanging fruits towards #1052. Achieves a ~15% improvement.
Before:
After: