[ECC] Cost enhancements #1405
Open
[ECC] Cost enhancements #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # TODO https://github.com/quantumlib/Qualtran/issues/1261 | ||
| if cost_key == QubitCount(): | ||
| return self.n + 1 | ||
| return NotImplemented | ||
|
|
||
|
|
||
| @frozen |
There was a problem hiding this comment.
there is no need for this shim. you can use the LinearDepthGreaterThan bloq
| return NotImplemented | ||
|
|
||
|
|
||
| @frozen |
There was a problem hiding this comment.
why a shim? why not use the QROM bloq itself (with Shaped as data)?
| return {ECAddR(n=self.n, R=self.point): self.n, MeasureQFT(n=self.n): 1} | ||
| def build_call_graph(self, ssa: 'SympySymbolAllocator') -> Set['BloqCountT']: | ||
| return { | ||
| (self.ec_add(R=self.point), self.n / (2**self.window_size)), |
| @@ -132,8 +142,11 @@ def signature(self) -> 'Signature': | |||
| ) | |||
|
|
|||
| def build_call_graph(self, ssa: 'SympySymbolAllocator') -> 'BloqCountDictT': | |||
| # Roetteler montgomery | |||
| return {Toffoli(): ceil(16 * self.n**2 * log2(self.n) - 26.3 * self.n**2)} | |||
| # Roetteler 2017 montgomery multiplier | |||
There was a problem hiding this comment.
do we want to keep this comment?
| @@ -115,7 +116,8 @@ def build_composite_bloq(self, bb: 'BloqBuilder', x: Soquet, y: Soquet) -> Dict[ | |||
| x = bb.join(x_split[1:], dtype=QMontgomeryUInt(bitsize=self.bitsize)) | |||
|
|
|||
| # Add constant -p to the y register. | |||
| y = bb.add(AddK(bitsize=self.bitsize + 1, k=-1 * self.mod, signed=True, cvs=()), x=y) | |||
| # FIXME: signed addition not large enough to fit `self.bitsize`-ed number. | |||
There was a problem hiding this comment.
this addition is unsiged ... it doesn't need fixing ... the flag sigend=True was wrong and you just fixed it... AddK will do the right thing for -p
Qualtran/qualtran/bloqs/arithmetic/addition.py
Lines 462 to 467 in 0f4deee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NoureldinYosri can you take a look