Add resource estimation notebook for trotterized QPE #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@fdmalone can you resolve the conflicts? I think most of them are vestigial from being factored out into other PRs, right? |
|
For sure
…On Thu, May 9, 2024 at 2:53 PM Matthew Harrigan ***@***.***> wrote:
@fdmalone <https://github.com/fdmalone> can you resolve the conflicts? I
think most of them are vestigial from being factored out into other PRs,
right?
—
Reply to this email directly, view it on GitHub
<#753 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC4JSVAVYTAEXVXNFY437QLZBPV5LAVCNFSM6AAAAABELTKJRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGQ3TINJSGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
fdmalone
force-pushed
the
add_resource_estimation_notebook
branch
from
cb1d6fa to
e7ee9d3
Compare
tanujkhattar
approved these changes
May 13, 2024
qualtran/bloqs/chemistry/trotter/hubbard/qpe_cost_optimization.ipynb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #743 (and the preceding PRs) to add a notebook which numerically and symbolically analyzes the T counts for the PLAQ hubbard bloqs (without HWP). I've kept it how I sort of wrote it chronologically but I'm open to removing some of the hand written cost code in favour of "here are the symbolic counts lets use those instead). I didn't have much luck with scipy's constrained optimization so just did a pretty basic inner/outer minimization step over two of the parameters which seems to work better than doing anything fancy.