Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move symbolic_counting_utils.py to a new module in qualtran/symbolics/ #941

Merged

Conversation

tanujkhattar
Copy link
Collaborator

With improved typing, we want to use types like SymbolicInt etc everywhere, including qualtran/_infra. This leads to cyclic imports since qualtran/resource_counting/ depends on qualtran/_infra. Moving symbolic utils to its own module helps avoid these cyclic imports and provides the right place to add future utilities for dealing with symbolics

@tanujkhattar tanujkhattar enabled auto-merge (squash) May 11, 2024 11:42
@tanujkhattar tanujkhattar merged commit 717c18f into quantumlib:main May 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants