Merge pull request #18 from quantumlib/numpy-version

Make __array__ safe for numpy < 2
quantumlib · Nov 11, 2024 · a3c5d2a · a3c5d2a
2 parents ec72ad5 + 7813245
commit a3c5d2a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/.github/workflows/prerelease.yml b/.github/workflows/prerelease.yml
@@ -91,12 +91,10 @@ jobs:
         user: __token__
         password: ${{ secrets.TEST_PYPI_API_TOKEN }}
         packages_dir: wheelhouse/
-        verbose: true
 
     - name: Publish package to pypi
       uses: pypa/gh-action-pypi-publish@27b31702a0e7fc50959f5ad993c78deac1bdfc29
       with:
         user: __token__
         password: ${{ secrets.PYPI_API_TOKEN }}
         packages_dir: wheelhouse/
-        verbose: true
diff --git a/.github/workflows/stable-release-workflow.yml b/.github/workflows/stable-release-workflow.yml
@@ -90,12 +90,10 @@ jobs:
         user: __token__
         password: ${{ secrets.TEST_PYPI_API_TOKEN }}
         packages_dir: wheelhouse/
-        verbose: true
 
     - name: Publish package to pypi
       uses: pypa/gh-action-pypi-publish@27b31702a0e7fc50959f5ad993c78deac1bdfc29
       with:
         user: __token__
         password: ${{ secrets.PYPI_API_TOKEN }}
         packages_dir: wheelhouse/
-        verbose: true
diff --git a/tunits/core/cython/with_unit_value_array.pyx b/tunits/core/cython/with_unit_value_array.pyx
@@ -75,8 +75,9 @@ class ValueArray(WithUnit):
 
     def __array__(WithUnit self, dtype=None, copy: bool=False):
         if self.is_dimensionless:
+            # TODO: pass copy to np.asarray.
             return np.asarray(conversion_to_double(self.conv) * self.value,
-                              dtype=dtype, copy=copy)
+                              dtype=dtype)
 
         unit_array = np.full_like(self.value, self.unit, dtype=object)
         result = self.value * unit_array