Make jupyter/Dockerfile build again #945
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Dockerfile failed to build for me due to changes in more recent versions of Jupyter and Ubuntu. These changes make it work, and also address lint errors reported by `hadolint`.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully fixes the build for jupyter/Dockerfile by downgrading packages and restructuring the Dockerfile commands. The changes to pin package versions and optimize apt-get usage are excellent for reproducibility and efficiency. I've identified a couple of areas for further improvement to enhance layer caching and ensure fully reproducible builds, which I've detailed in the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jupyter/Dockerfilefailed to build for me due to changes in more recent versions of Jupyter and Ubuntu. Downgrading some packages likenotebookand using a different combination of commands for the notebook extensions resolved the failures.In addition, this PR also addresses lint errors reported by
hadolint.