Reformat cuquantum_configure.bzl using Buildifier #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed this file in PR quantumlib#948
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reformats cuquantum_configure.bzl using Buildifier, which improves code style and consistency. The changes are mostly cosmetic, involving whitespace and line breaks. While reviewing the formatting changes, I noticed a pre-existing issue in the _find_file function. The find command is not correctly structured to exclude dot-directories as was likely intended. I've provided a suggestion to fix this logic.
From the review comment by Gemini Code Assist on GitHub: > The find command has a logic error. The `-quit` primary causes find to > exit immediately after printing the first match, so the subsequent > `-not -path "'*/.*'"` condition is never evaluated. This means the > intended filtering of dot-directories (like `.git`) is not happening. > Additionally, the single quotes in `"'*/.*'"` are passed literally to > find, which is incorrect as `repository_ctx.execute` does not use a shell > to strip them. > To correctly and robustly exclude dot-directories from the search, the > command should be modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this file in PR #948