-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MessageConsumer XA Commit and Rollback tests for artemis-jms #320
Conversation
Thanks @DreamPearl for your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A thanks from me too @DreamPearl
...s/jms/common/src/main/java/io/quarkus/it/artemis/jms/common/ArtemisJmsXaConsumerManager.java
Outdated
Show resolved
Hide resolved
@turing85 The first check is failing, is there anything we need to concern? |
You mean the |
Hmm, I get it. Anyway, it seems better if we can make it work against the PRs from forked projects. |
@turing85 Do you think we need backport these tests to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, found something. This is only indirectly related to the PR. The exception case was not triggered until now, and I suspect you copied from the ArtemisJmsConsumerManager
. Could you incorporate these changes?
...s/jms/common/src/main/java/io/quarkus/it/artemis/jms/common/ArtemisJmsXaConsumerManager.java
Show resolved
Hide resolved
@DreamPearl one last request: could you squash the PR down to one (semantic) commit? This will simplify cherry-picking for the backports 🙂 |
Done! |
...ration-tests/jms/common/src/test/java/io/quarkus/it/artemis/jms/common/ArtemisJmsHelper.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment, but let's not overcomplicate adding a test. Thanks!
...s/jms/common/src/main/java/io/quarkus/it/artemis/jms/common/ArtemisJmsXaConsumerManager.java
Show resolved
Hide resolved
Add MessageConsumer XA Commit and Rollback tests Add XA Commit and Rollback tests
@all-contributors Please add @DreamPearl for code |
I've put up a pull request to add @DreamPearl! 🎉 |
What do you mean by "we need these tests"? Do you need them on your end? We normally do not release for minor changes, but I am open to produce a release. @louisa-fr @middagj @zhfeng What do you think? Can we produce a release? If we do, I would suggest producing a patch-level release on all three branches ( |
Ah cool. In that case, we will just backport these tests to our branch. Sorry to bother and thanks! |
Let's see what the team says 🙂 as I said: I am open to producing a release. |
We don't release tests, do we? If someone can be helped with a release of some small fixes, I am okay with it. But I don't see what we release here. |
Huh... true. I double-checked. The jars that we release only contain the non-test code. |
Resolves #319