Add a new components to CDI. #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. LGTM |
orekyuu
force-pushed
the
add-new-components-to-cdi
branch
from
c23d2c0 to
c7decfd
Compare
orekyuu
force-pushed
the
add-new-components-to-cdi
branch
from
c7decfd to
884c08e
Compare
nakamura-to
requested changes
Feb 10, 2025
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
| import static org.junit.jupiter.api.Assertions.*; |
orekyuu
force-pushed
the
add-new-components-to-cdi
branch
from
b704291 to
3f5da36
Compare
# Conflicts: # deployment/src/main/java/io/quarkiverse/doma/deployment/DomaBuildTimeConfig.java
nakamura-to
approved these changes
Feb 25, 2025
Comment on lines
+340
to
+342
| this.duplicateColumnHandler = duplicateColumnHandler; | ||
| this.sqlBuilderSettings = sqlBuilderSettings; | ||
| this.statisticManager = statisticManager; |
There was a problem hiding this comment.
I think it would be better to have null checks for the following parameters, just like the other parameters.
- duplicateColumnHandler
- sqlBuilderSettings
- statisticManager
| @@ -115,4 +126,25 @@ public interface DataSourceBuildTimeConfig { | |||
| @ConfigDocDefault("import.sql in DEV, TEST ; no-file otherwise") | |||
| Optional<String> sqlLoadScript(); | |||
| } | |||
|
|
|||
| @ConfigGroup | |||
| public interface SqlBuilderBuildTimeConfig { | |||
There was a problem hiding this comment.
SqlBuilderSettingsBuildTimeConfig might be a more consistent name, though it is somewhat redundant.
| @Singleton | ||
| @DefaultBean | ||
| DuplicateColumnHandler duplicateColumnHandler() { | ||
| return duplicateColumnHandler; |
There was a problem hiding this comment.
It seems better to have a null check to align with other parts.
|
In the Pull Request description, should sql-builder-settings.should-remove-blank-lines actually be quarkus.doma.sql-builder-settings.should-remove-blank-lines? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following components added to Doma2 will be managed by CDI.
Add new configuration property:
If DuplicateColumnHandler or SqlBuilderSettings is registered in CDI, these properties will be ignored.