Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Virtual Threads in the WorkManager #152

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Support Virtual Threads in the WorkManager #152

wants to merge 1 commit into from

Conversation

gastaldi
Copy link
Member

@gastaldi gastaldi commented Jan 24, 2025

@gastaldi gastaldi requested a review from a team as a code owner January 24, 2025 15:49
@gastaldi gastaldi marked this pull request as draft January 24, 2025 16:08
@maxandersen
Copy link
Member

good we are exploring the abilty of virtual threads - but I noticed the use of a global virtual thread on/off switch. Something we've avoided elsewhere (so far).

Is having a global property the right way of doing this? anywhere else we explicitly require use of annotation at the entry point to make it very clear and explicit the execution model is different.

so this is not -1'ing the idea; just checking this really is the best way to expose VT in JCA.

@gastaldi
Copy link
Member Author

@maxandersen thank you for your feedback. I thought about reading that annotation from the ResourceAdapterFactory implementation, maybe that's a better idea than a global build setting.

I'll experiment a bit before marking this PR as ready

@gastaldi gastaldi force-pushed the vt branch 5 times, most recently from ae43cdd to daa5e7b Compare January 30, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Virtual Threads
2 participants