feat(kubernetes): use custom ToolResponseEncoder for common serialization #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manusa
force-pushed
the
refactor/use-custom-encoder
branch
from
ebdc627 to
a7d7f41
Compare
Improves capabilities for debugging serialization and other Quarkus MCP server extension features.
manusa
force-pushed
the
refactor/use-custom-encoder
branch
from
ddcdedc to
a573121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fabric8io/kubernetes-client#6870
Note that for collection return types, using a
Listinstead ofCollectionwill break the current behavior.I understand that this might have something to do with:
https://github.com/quarkiverse/quarkus-mcp-server/blob/95649c2095a53cdd0595c1eb26e413ca6b9e2395/core/deployment/src/main/java/io/quarkiverse/mcp/server/deployment/McpServerProcessor.java#L659-L682
and the result being serialized or deserialized before passing it on to the customized
ToolResponseEncoder.You can check this by changing the return type of the
resources_listtoCollection<GenericKubernetesResource>.The integration test will fail because the customized ObjectMapper won't work because the objects in the list probably are no longer GenericKubernetesResource.