Fix and refactor the scope of some resources #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pleas add commit similar to c48ec1d to increase the memory to 8g |
rsvoboda
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in
TestResourceScope.MATCHING_RESOURCESwhich made this work and was fixed in quarkusio/quarkus#44279, I change it in this PR #505 but it seems I wrongy understand the docs back then.Now it should work as:
RESTRICTED_TO_CLASSstart for every test class, every test class need anotationMATCHING_RESOURCESstart for specific group of test classes, every test class need anotationGLOBALstart for every test class, only one annotationI change it to cover all 3 usages.