Skip to content

Commit

Permalink
Enable disabled tests and stop using deploymentconfig
Browse files Browse the repository at this point in the history
  • Loading branch information
fedinskiy committed Feb 13, 2024
1 parent a4de972 commit e0c38fc
Show file tree
Hide file tree
Showing 36 changed files with 18 additions and 92 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

import org.awaitility.core.ThrowingRunnable;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;

Expand Down Expand Up @@ -111,7 +110,6 @@ public void timeoutPropertyRecognized() {
verifyDevModePropertyRecognized(app, QUARKUS_ANALYTICS_TIMEOUT_PROPERTY);
}

@Disabled("https://github.com/quarkusio/quarkus/issues/34825")
@Test
public void uriPropertyRecognized() {
QuarkusCliRestService app = createAppDefault();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import static io.quarkus.ts.buildtimeanalytics.AnalyticsUtils.QUARKUS_ANALYTICS_URI_BASE_PROPERTY;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;

Expand Down Expand Up @@ -116,7 +115,6 @@ public void timeoutPropertyRecognized() {
verifyBuildPropertyRecognized(buildResult, QUARKUS_ANALYTICS_TIMEOUT_PROPERTY);
}

@Disabled("https://github.com/quarkusio/quarkus/issues/34825")
@Test
public void uriPropertyRecognized() {
QuarkusCliRestService app = createAppDefault();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
package io.quarkus.ts.configmap.api.server;

import org.junit.jupiter.api.Disabled;

import io.quarkus.test.bootstrap.RestService;
import io.quarkus.test.services.QuarkusApplication;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
public class OpenShiftApiServerConfigMapConfigIT extends OpenShiftBaseConfigIT {

@QuarkusApplication
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
package io.quarkus.ts.configmap.api.server;

import org.junit.jupiter.api.Disabled;

import io.quarkus.test.bootstrap.RestService;
import io.quarkus.test.services.QuarkusApplication;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
public class OpenShiftApiServerConfigSecretConfigIT extends OpenShiftBaseConfigIT {

@QuarkusApplication
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import jakarta.inject.Inject;

import org.apache.http.HttpStatus;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import io.quarkus.test.bootstrap.RestService;
Expand All @@ -32,7 +31,6 @@
import io.restassured.response.Response;

@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
public class OpenShiftConfigSourcePriorityIT {

private static final String CONFIGMAP_YAML = CONFIGMAP + "-yaml";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import io.quarkus.test.services.QuarkusApplication;

@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
public class OpenShiftFailOnMissingConfigIT {

@QuarkusApplication
Expand All @@ -21,6 +20,7 @@ public class OpenShiftFailOnMissingConfigIT {
.withProperty("quarkus.kubernetes-config.config-maps", "absent-config-map");

@Test
@Disabled("We can not detect this failure at the moment due to https://github.com/quarkusio/quarkus/issues/38481")
public void shouldFailOnStart() {
assertThrows(AssertionError.class, () -> app.start(),
"Should fail because property 'quarkus.kubernetes-config.fail-on-missing-config' is true and ConfigMap 'absent-config-map' is missing.");
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
package io.quarkus.ts.configmap.api.server;

import org.junit.jupiter.api.Disabled;

import io.quarkus.test.bootstrap.RestService;
import io.quarkus.test.services.QuarkusApplication;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
public class OpenShiftFileSystemConfigMapConfigIT extends OpenShiftBaseConfigIT {

@QuarkusApplication
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
package io.quarkus.ts.configmap.api.server;

import org.junit.jupiter.api.Disabled;

import io.quarkus.test.bootstrap.RestService;
import io.quarkus.test.services.QuarkusApplication;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
public class OpenShiftFileSystemConfigSecretConfigIT extends OpenShiftBaseConfigIT {

@QuarkusApplication
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import java.util.Set;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledIfSystemProperty;
Expand All @@ -32,7 +31,6 @@
@Tag("use-quarkus-openshift-extension")
@Tag("serverless")
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
public class ServerlessExtensionOpenShiftFunqyKnEventsIT {

@QuarkusApplication
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ void setUp() {
}

@Test
@Disabled("https://github.com/quarkusio/quarkus/issues/30511")
@Disabled("Wait for this to be fixed https://github.com/HtmlUnit/htmlunit/issues/232 or rewrite from HtmlUnit")
public void uiChange() throws IOException {
RestService app = getApp();
URILike uri = getUri();

HtmlPage before = webClient.getPage(uri.withPath("/q/dev/io.quarkus.quarkus-vertx-http/config").toString());
HtmlPage before = webClient.getPage(uri.withPath("/q/dev-ui/configuration-form-editor").toString());
QuarkusUIField field = new QuarkusUIField(before.getElementById(PROPERTY));
assertEquals("42", field.getValue(), "Wrong initial value shown in UI!");
assertEquals("42", app.getProperty(PROPERTY, ""), "Properties contain wrong initial value!");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
import io.quarkus.example.StreamingGrpc;
import io.quarkus.test.bootstrap.Protocol;
import io.quarkus.test.bootstrap.RestService;
import io.quarkus.test.scenarios.annotations.DisabledOnNative;
import io.quarkus.test.scenarios.annotations.EnabledOnQuarkusVersion;
import io.quarkus.ts.http.advanced.reactive.clients.HttpVersionClientService;
import io.quarkus.ts.http.advanced.reactive.clients.HttpVersionClientServiceAsync;
Expand Down Expand Up @@ -450,7 +449,6 @@ public void interceptedTest() {
@DisplayName("SSE check for event responses values containing empty data")
@Test
@Tag("QUARKUS-3701")
@DisabledOnNative(reason = "https://github.com/quarkusio/quarkus/issues/36986")
void testSseResponseForEmptyData() {
getApp().given()
.get(ROOT_PATH + "/sse/client-update")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package io.quarkus.ts.http.minimum.reactive;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;

import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy;
import io.quarkus.test.scenarios.OpenShiftScenario;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@Tag("use-quarkus-openshift-extension")
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtensionAndDockerBuildStrategy)
public class OpenShiftUsingExtensionDockerBuildStrategyHttpMinimumReactiveIT extends HttpMinimumReactiveIT {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package io.quarkus.ts.http.minimum.reactive;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;

import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy;
import io.quarkus.test.scenarios.OpenShiftScenario;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@Tag("use-quarkus-openshift-extension")
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
public class OpenShiftUsingExtensionHttpMinimumReactiveIT extends HttpMinimumReactiveIT {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package io.quarkus.ts.http.minimum;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;

import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy;
import io.quarkus.test.scenarios.OpenShiftScenario;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@Tag("use-quarkus-openshift-extension")
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtensionAndDockerBuildStrategy)
public class OpenShiftUsingExtensionDockerBuildStrategyHttpMinimumIT extends HttpMinimumIT {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package io.quarkus.ts.http.minimum;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;

import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy;
import io.quarkus.test.scenarios.OpenShiftScenario;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@Tag("use-quarkus-openshift-extension")
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
public class OpenShiftUsingExtensionHttpMinimumIT extends HttpMinimumIT {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
package io.quarkus.ts.http.jakartarest.reactive;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;

import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy;
import io.quarkus.test.scenarios.OpenShiftScenario;
import io.quarkus.test.scenarios.annotations.DisabledOnNative;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@Tag("use-quarkus-openshift-extension")
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
// OCP Native coverage is not required (Test plan QUARKUS-2487), due to a lack of resources and the ROI.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
package io.quarkus.ts.http.jakartarest.reactive;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;

import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy;
import io.quarkus.test.scenarios.OpenShiftScenario;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@Tag("use-quarkus-openshift-extension")
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
public class OpenShiftHttpCachingIT extends HttpCachingIT {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
package io.quarkus.qe.extension;

import org.junit.jupiter.api.Disabled;

import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy;
import io.quarkus.test.scenarios.OpenShiftScenario;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtensionAndDockerBuildStrategy)
public class OpenShiftDockerBuildIT extends OpenShiftBaseDeploymentIT {
@Override
@Disabled("https://github.com/quarkusio/quarkus/issues/34645")
public void health() {
}
}
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
package io.quarkus.qe.extension;

import org.junit.jupiter.api.Disabled;

import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy;
import io.quarkus.test.scenarios.OpenShiftScenario;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
public class OpenShiftExtensionIT extends OpenShiftBaseDeploymentIT {
@Override
@Disabled("https://github.com/quarkusio/quarkus/issues/34645")
public void health() {
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.quarkus.ts.vertx;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;

import io.quarkus.test.bootstrap.RestService;
Expand All @@ -9,7 +8,6 @@
import io.quarkus.test.services.QuarkusApplication;
import io.restassured.specification.RequestSpecification;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@Tag("use-quarkus-openshift-extension")
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtensionAndDockerBuildStrategy)
public class OpenShiftUsingExtensionDockerBuildStrategyVertxIT extends AbstractVertxIT {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.quarkus.ts.vertx;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;

import io.quarkus.test.bootstrap.RestService;
Expand All @@ -9,7 +8,6 @@
import io.quarkus.test.services.QuarkusApplication;
import io.restassured.specification.RequestSpecification;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@Tag("use-quarkus-openshift-extension")
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
public class OpenShiftUsingExtensionVertxIT extends AbstractVertxIT {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.quarkus.ts.vertx;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.condition.DisabledIfSystemProperty;

Expand All @@ -10,7 +9,6 @@
import io.quarkus.test.services.QuarkusApplication;
import io.restassured.specification.RequestSpecification;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@DisabledIfSystemProperty(named = "ts.arm.missing.services.excludes", matches = "true", disabledReason = "https://github.com/quarkus-qe/quarkus-test-suite/issues/1142")
@Tag("use-quarkus-openshift-extension")
@Tag("serverless")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.quarkus.ts.vertx;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.condition.DisabledIfSystemProperty;

Expand All @@ -10,7 +9,6 @@
import io.quarkus.test.services.QuarkusApplication;
import io.restassured.specification.RequestSpecification;

@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
@DisabledIfSystemProperty(named = "ts.arm.missing.services.excludes", matches = "true", disabledReason = "https://github.com/quarkus-qe/quarkus-test-suite/issues/1142")
@Tag("use-quarkus-openshift-extension")
@Tag("serverless")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import org.apache.http.HttpStatus;
import org.hamcrest.Matchers;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.MethodOrderer;
import org.junit.jupiter.api.Order;
import org.junit.jupiter.api.Test;
Expand All @@ -27,7 +26,6 @@

@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
public class OperatorOpenShiftInfinispanCountersIT extends BaseOpenShiftInfinispanIT {

private static final AtomicBoolean CLUSTER_CREATED = new AtomicBoolean(false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import org.apache.http.HttpStatus;
import org.hamcrest.Matcher;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.MethodOrderer;
import org.junit.jupiter.api.Order;
import org.junit.jupiter.api.Test;
Expand All @@ -28,7 +27,6 @@

@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
@Disabled("https://github.com/quarkusio/quarkus/issues/38018")
public class OperatorOpenShiftInfinispanObjectsIT extends BaseOpenShiftInfinispanIT {

private static final int CACHE_ENTRY_MAX = 5;
Expand Down Expand Up @@ -96,7 +94,6 @@ public void testQueryOnSerializedObjects() {

@Test
@Order(4)
@Disabled("https://issues.redhat.com/browse/ISPN-13292")
public void testCacheEvictionByLifespanAndIdleTime() {
whenAddCacheItemsWithLifespanAndIdleTime(maxThresholdItemList, CACHE_LIFESPAN_SEC + 20, CACHE_IDLE_TIME_SEC);
await().pollDelay(Duration.ofSeconds(15)).atMost(Duration.ofSeconds(20)).untilAsserted(() -> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import org.apache.http.HttpStatus;
import org.jboss.logging.Logger;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import io.quarkus.test.bootstrap.RestService;
Expand All @@ -28,7 +27,6 @@
* - `prime_number_test_{uniqueId}`: with information about the calculation of the prime number.
*/
@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension)
@Disabled("https://github.com/quarkusio/quarkus/issues/34645")
public class OpenShiftCustomMetricsIT {

private static final Logger LOG = Logger.getLogger(OpenShiftCustomMetricsIT.class);
Expand Down
Loading

0 comments on commit e0c38fc

Please sign in to comment.