Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports/3.8 16.02 #1668

Merged
merged 11 commits into from
Feb 19, 2024
Merged

Conversation

fedinskiy
Copy link
Contributor

@fedinskiy fedinskiy commented Feb 16, 2024

Summary

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy self-assigned this Feb 16, 2024
@fedinskiy fedinskiy marked this pull request as ready for review February 16, 2024 14:23
@fedinskiy
Copy link
Contributor Author

run tests

@fedinskiy
Copy link
Contributor Author

#1667 was added

run tests

@michalvavrik
Copy link
Member

Please check OCP failures.

@fedinskiy
Copy link
Contributor Author

fedinskiy commented Feb 19, 2024

OCP failures are due to this commit: ce5924a and they are sort-of intended. I suppose, we need to drop this test.

UPD: the test is completely disabled here: #1671

It is disabled for 2.x, 999-SNAPSHOT and on 3.2 branch already
@fedinskiy
Copy link
Contributor Author

run tests

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@michalvavrik
Copy link
Member

Looks like there is no choice, the 3.8 branch requires squashing this :/

@michalvavrik michalvavrik merged commit 90dcdf1 into quarkus-qe:3.8 Feb 19, 2024
8 checks passed
@fedinskiy fedinskiy deleted the backports/3.8-16.02 branch February 19, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants