Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Quarkus Parameter for Disabling Uber-JAR File Name Suffix #45205

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Quarkus Parameter for Disabling Uber-JAR File Name Suffix #45205

wants to merge 2 commits into from

Conversation

jjpinto
Copy link

@jjpinto jjpinto commented Dec 19, 2024 •
edited by geoand
Loading

Updating a Quarkus parameter and the specific context of the Uber-JAR file name suffix.

@jjpinto jjpinto mentioned this pull request Dec 19, 2024
Closed
geoand
geoand approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

🎊 PR Preview 4f943d5 has been successfully built and deployed to https://quarkus-pr-main-45205-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
geoand
geoand requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I misread the change. See #45204 (comment)

@geoand geoand removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 19, 2024
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor

geoand commented Dec 20, 2024

Can you please rebase the change onto main and squash the commits?

Thanks

gsmet
gsmet requested changes Dec 20, 2024
View reviewed changes
docs/src/main/asciidoc/maven-tooling.adoc Outdated Show resolved Hide resolved
jjpinto
jjpinto commented Dec 23, 2024
View reviewed changes
Copy link
Author

@jjpinto jjpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@geoand
Copy link
Contributor

geoand commented Dec 23, 2024

Cool!

Can you please squash the commits and rebase onto main?

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@jjpinto jjpinto requested review from geoand and gsmet December 23, 2024 17:01
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@jjpinto
Copy link
Author

jjpinto commented Dec 23, 2024

Cool!

Can you please squash the commits and rebase onto main?
It seems that was rebased but it shows an error in the merge commit. Any help would be great! Thanks

@geoand
Copy link
Contributor

geoand commented Dec 23, 2024

No problem, I'll take care of it tomorrow

@geoand
Copy link
Contributor

geoand commented Dec 24, 2024

PR updated!

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Dec 24, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 7c6785f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uber-Jar file name suffix issue for disabling it
3 participants
@jjpinto @geoand @gsmet