Assorted @WithTestResource fixes #45253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we were comparing items with and without this entry, leading to us restarting Quarkus a lot more often than necessary. Spotted while playing with a modified version of @WithKubernetesTestServer/
|
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commit are just some doc fixes and a typo fix... but the third one is actually a real bug fix.
When determining if Quarkus should be restarted or not in a test, we were comparing items in which we were injecting an additional
configAnnotationentry with items for which we didn't. Which led to some unnecessary restarts.I stumbled upon this while working on a modified version of
@WithKubernetesTestServerwhich was not restricted to class.