Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC: optimize "List all" injection points #45526

Merged
merged 1 commit into from
Jan 13, 2025
Merged

ArC: optimize "List all" injection points #45526

merged 1 commit into from
Jan 13, 2025
+39 −20

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 13, 2025

  • only collect InjectionPoint metadata if any of the resolved beans is dependent

@mkouba
ArC: optimize "List all" injection points
e42d2ed 
- only collect InjectionPoint metadata if any of the resolved beans is
dependent
@mkouba
Copy link
Contributor Author

mkouba commented Jan 13, 2025

CC @geoand

@mkouba mkouba requested review from Ladicek and manovotn January 13, 2025 10:06
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Jan 13, 2025
@geoand
Copy link
Contributor

geoand commented Jan 13, 2025

Thanks @mkouba!

@Ladicek
Copy link
Contributor

Ladicek commented Jan 13, 2025

Just wondering, what happens if there is an invalid InjectionPoint IP?

@mkouba
Copy link
Contributor Author

mkouba commented Jan 13, 2025

Just wondering, what happens if there is an invalid InjectionPoint IP?

Invalid in which sense?

@Ladicek
Copy link
Contributor

Ladicek commented Jan 13, 2025

Invalid for example when declared on a non-dependent bean.

@mkouba
Copy link
Contributor Author

mkouba commented Jan 13, 2025

Invalid for example when declared on a non-dependent bean.

It should fail during build: https://github.com/quarkusio/quarkus/blob/main/independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BuiltinBean.java#L517-L527

@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 13, 2025
@Ladicek
Copy link
Contributor

Ladicek commented Jan 13, 2025

OK, thanks!

@gsmet gsmet merged commit a202b44 into quarkusio:main Jan 13, 2025
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 13, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 13, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 13, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e42d2ed.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
3.18 - main
Development

Successfully merging this pull request may close these issues.
5 participants
@mkouba @geoand @Ladicek @manovotn @gsmet