Skip to content

Bump smallrye-health to 4.3.0 #50911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

Bump smallrye-health to 4.3.0 #50911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<microprofile-openapi.version>4.1.1</microprofile-openapi.version>
<smallrye-common.version>2.13.9</smallrye-common.version>
<smallrye-config.version>3.14.1</smallrye-config.version>
<smallrye-health.version>4.2.0</smallrye-health.version>
<smallrye-health.version>4.3.0</smallrye-health.version>
<smallrye-metrics.version>4.0.0</smallrye-metrics.version>
<smallrye-open-api.version>4.2.0</smallrye-open-api.version>
<smallrye-graphql.version>2.16.0</smallrye-graphql.version>
Expand Down
3 changes: 2 additions & 1 deletion ...ployment/src/main/java/io/quarkus/smallrye/health/deployment/SmallRyeHealthProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,8 @@ public void defineHealthRoutes(BuildProducer<RouteBuildItem> routes,
public void processSmallRyeHealthConfigValues(SmallRyeHealthBuildTimeConfig healthConfig,
BuildProducer<RunTimeConfigurationDefaultBuildItem> config) {
if (healthConfig.contextPropagation()) {
config.produce(new RunTimeConfigurationDefaultBuildItem("io.smallrye.health.context.propagation", "true"));
LOG.warn(
"The config property quarkus.smallrye-health.context-propagation is deprecated and will be removed. The context is now always propagated.");
Copy link
Member

@gsmet gsmet Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mark the property as @Deprecated(since = "3.30, forRemoval = true)`?

}
if (healthConfig.maxGroupRegistriesCount().isPresent()) {
config.produce(new RunTimeConfigurationDefaultBuildItem("io.smallrye.health.maxGroupRegistriesCount",
Expand Down
1 change: 0 additions & 1 deletion ...ment/src/test/java/io/quarkus/smallrye/health/test/HealthCheckContextPropagationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class HealthCheckContextPropagationTest {

@RegisterExtension
static final QuarkusUnitTest config = new QuarkusUnitTest()
.overrideConfigKey("quarkus.smallrye-health.context-propagation", "true")
.withApplicationRoot((jar) -> jar
.addClasses(RequestScopedBean.class, ContextualHC.class));

Expand Down
8 changes: 4 additions & 4 deletions ...llrye-health/deployment/src/test/java/io/quarkus/smallrye/health/test/HealthObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import org.eclipse.microprofile.health.Liveness;
import org.eclipse.microprofile.health.Readiness;

import io.smallrye.health.api.event.HealthStatusChangeEvent;
import io.smallrye.health.event.SmallRyeHealthStatusChangeEvent;

@ApplicationScoped
public class HealthObserver {
Expand All @@ -16,15 +16,15 @@ public class HealthObserver {
public static int readinessChangeCounter = 0;
public static int livenessChangeCounter = 0;

public void observeHealthChange(@Observes @Default HealthStatusChangeEvent event) {
public void observeHealthChange(@Observes @Default SmallRyeHealthStatusChangeEvent event) {
healthChangeCounter++;
}

public void observeReadinessChange(@Observes @Readiness HealthStatusChangeEvent event) {
public void observeReadinessChange(@Observes @Readiness SmallRyeHealthStatusChangeEvent event) {
readinessChangeCounter++;
}

public void observeLivenessChange(@Observes @Liveness HealthStatusChangeEvent event) {
public void observeLivenessChange(@Observes @Liveness SmallRyeHealthStatusChangeEvent event) {
livenessChangeCounter++;
}
}
Loading