Skip to content

Conversation

@gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Nov 7, 2025

It also avoids using deprecated API

It also avoids using deprecated API
@gastaldi gastaldi requested a review from gsmet November 7, 2025 14:43
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/flyway labels Nov 7, 2025
@gastaldi gastaldi requested review from Sanne and Copilot November 7, 2025 14:43
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Flyway extension to version 11.16.0 and adapts the code to accommodate API changes introduced in this version.

  • Updates Flyway dependency from version 11.15.0 to 11.16.0
  • Refactors QuarkusPathLocationScanner to use new Flyway API classes and methods
  • Removes deprecated API usages in favor of the new Flyway 11.16.0 API

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
bom/application/pom.xml Updates Flyway version from 11.15.0 to 11.16.0
extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/QuarkusPathLocationScanner.java Adapts to Flyway 11.16.0 API changes: uses CoreLocationPrefix, LocationParser, updated FileSystemScanner constructor, and getRootPath() method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 7, 2025
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 7, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 26db2de.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Native Tests - Data1 Build Failures Logs Raw logs 🚧
Native Tests - Data7 Build Failures Logs Raw logs 🚧
JVM Integration Tests - JDK 17 Build Failures Logs Raw logs 🚧
✔️ JVM Integration Tests - JDK 17 Windows Logs Raw logs 🚧
JVM Integration Tests - JDK 21 Build Failures Logs Raw logs 🚧
JVM Integration Tests - JDK 25 Build Failures Logs Raw logs 🚧

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Data1 #

- Failing: integration-tests/hibernate-orm-tenancy/datasource 

📦 integration-tests/hibernate-orm-tenancy/datasource

io.quarkus.it.hibernate.multitenancy.fruit.HibernateTenancyFunctionalityInGraalITCase.testGetFruitsDefaultTenant - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.throwBootFailureException(QuarkusIntegrationTestExtension.java:347)
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.beforeEach(QuarkusIntegrationTestExtension.java:114)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
	at io.quarkus.test.common.LauncherUtil.waitForCapturedListeningData(LauncherUtil.java:98)
	at io.quarkus.test.common.DefaultNativeImageLauncher.start(DefaultNativeImageLauncher.java:116)

⚙️ Native Tests - Data7 #

- Failing: integration-tests/hibernate-reactive-mysql-agroal-flyway 

📦 integration-tests/hibernate-reactive-mysql-agroal-flyway

io.quarkus.it.hibernate.reactive.mysql.HibernateReactiveMySQLInGraalIT.reactivePersist - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.throwBootFailureException(QuarkusIntegrationTestExtension.java:347)
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.beforeEach(QuarkusIntegrationTestExtension.java:114)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
	at io.quarkus.test.common.LauncherUtil.waitForCapturedListeningData(LauncherUtil.java:98)
	at io.quarkus.test.common.DefaultNativeImageLauncher.start(DefaultNativeImageLauncher.java:116)

⚙️ JVM Integration Tests - JDK 17 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers integration-tests/hibernate-orm-tenancy/datasource and 2 more

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-hibernate-orm-tenancy-connection-resolver: I/O Error

📦 integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-hibernate-orm-tenancy-connection-resolver-legacy-qualifiers: I/O Error

📦 integration-tests/hibernate-orm-tenancy/datasource

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-hibernate-orm-tenancy-datasource: I/O Error

📦 integration-tests/hibernate-reactive-mysql-agroal-flyway

io.quarkus.it.hibernate.reactive.mysql.HibernateReactiveMySQLTest. - History - More details - Source on GitHub

org.junit.jupiter.engine.execution.ConditionEvaluationException: Failed to evaluate condition [io.quarkus.test.junit.QuarkusTestExtension]: Internal error: Test class was loaded with an unexpected classloader (QuarkusClassLoader:Quarkus Base Runtime ClassLoader: TEST for JUnitQuarkusTest-no-profile (QuarkusTest)@77998ea7) or the thread context classloader (jdk.internal.loader.ClassLoaders$AppClassLoader@5ffd2b27) was incorrect.
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1602)
	at java.base/java.util.stream.Referen...

io.quarkus.it.hibernate.reactive.mysql.HibernateReactiveMySQLTest.reactivePersist - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:666)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:761)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

📦 integration-tests/reactive-mysql-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-reactive-mysql-client: I/O Error


⚙️ JVM Integration Tests - JDK 21 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers integration-tests/hibernate-orm-tenancy/datasource and 2 more

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-hibernate-orm-tenancy-connection-resolver: I/O Error

📦 integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-hibernate-orm-tenancy-connection-resolver-legacy-qualifiers: I/O Error

📦 integration-tests/hibernate-orm-tenancy/datasource

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-hibernate-orm-tenancy-datasource: I/O Error

📦 integration-tests/hibernate-reactive-mysql-agroal-flyway

io.quarkus.it.hibernate.reactive.mysql.HibernateReactiveMySQLTest. - History - More details - Source on GitHub

org.junit.jupiter.engine.execution.ConditionEvaluationException: Failed to evaluate condition [io.quarkus.test.junit.QuarkusTestExtension]: Internal error: Test class was loaded with an unexpected classloader (QuarkusClassLoader:Quarkus Base Runtime ClassLoader: TEST for JUnitQuarkusTest-no-profile (QuarkusTest)@56499781) or the thread context classloader (jdk.internal.loader.ClassLoaders$AppClassLoader@c387f44) was incorrect.
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1685)
	at java.base/java.util.stream.Referenc...

io.quarkus.it.hibernate.reactive.mysql.HibernateReactiveMySQLTest.reactivePersist - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:666)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:761)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

📦 integration-tests/reactive-mysql-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-reactive-mysql-client: I/O Error


⚙️ JVM Integration Tests - JDK 25 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers integration-tests/hibernate-orm-tenancy/datasource and 2 more

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-hibernate-orm-tenancy-connection-resolver: I/O Error

📦 integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-hibernate-orm-tenancy-connection-resolver-legacy-qualifiers: I/O Error

📦 integration-tests/hibernate-orm-tenancy/datasource

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-hibernate-orm-tenancy-datasource: I/O Error

📦 integration-tests/hibernate-reactive-mysql-agroal-flyway

io.quarkus.it.hibernate.reactive.mysql.HibernateReactiveMySQLTest. - History - More details - Source on GitHub

org.junit.jupiter.engine.execution.ConditionEvaluationException: Failed to evaluate condition [io.quarkus.test.junit.QuarkusTestExtension]: Internal error: Test class was loaded with an unexpected classloader (QuarkusClassLoader:Quarkus Base Runtime ClassLoader: TEST for JUnitQuarkusTest-no-profile (QuarkusTest)@7cbf4f8c) or the thread context classloader (jdk.internal.loader.ClassLoaders$AppClassLoader@5bc2b487) was incorrect.
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:214)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:214)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:214)
	at java.base/java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1693)
	at java.base/java.util.stream.Referen...

io.quarkus.it.hibernate.reactive.mysql.HibernateReactiveMySQLTest.reactivePersist - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:666)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:761)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

📦 integration-tests/reactive-mysql-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.47.0:start (docker-start) on project quarkus-integration-test-reactive-mysql-client: I/O Error


Flaky tests - Develocity

⚙️ JVM Tests - JDK 25

📦 test-framework/jacoco/runtime

io.quarkus.jacoco.runtime.DataFileWatchTest.waitForDataFileThatNeverAppears - History

  • Expecting value to be false but was true - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 

Expecting value to be false but was true
	at io.quarkus.jacoco.runtime.DataFileWatchTest.waitForDataFileThatNeverAppears(DataFileWatchTest.java:208)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
  • Expecting value to be false but was true - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 

Expecting value to be false but was true
	at io.quarkus.jacoco.runtime.DataFileWatchTest.waitForDataFileThatNeverAppears(DataFileWatchTest.java:208)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed(MicrometerTimedInterceptorTest.java:150)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:534)

⚙️ MicroProfile TCKs Tests

📦 tcks/microprofile-lra

org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable - History

  • Expecting the metric Compensated callback was called Expected: a value equal to or greater than <1> but: <0> was less than <1> - java.lang.AssertionError
java.lang.AssertionError: 
Expecting the metric Compensated callback was called
Expected: a value equal to or greater than <1>
     but: <0> was less than <1>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.assertMetricCallbackCalled(TckRecoveryTests.java:210)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable(TckRecoveryTests.java:195)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Pull requests that update a dependency file area/flyway triage/flaky-test triage/waiting-for-ci Ready to merge when CI successfully finishes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants