Test that Mutiny can use SR-CP copy to propagate cancel() up from CompletableFuture
#50931
+28
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that any CF that Mutiny creates will be wrappers which forward cancellation upstream
This is only to validate the fix in CI, but it has to be committed in Mutiny itself.
FroMage
changed the title
copy to propagate cancel() up from CompletableFuture
Not surprised about this one, we're just reverting a9a0650 which was added when we last touched CP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that #50513 is resolved by checking what happens when we use the proper SR-CP
copysemantics for wrappers.