Skip to content

gRPC: Avoid repeatedly starting call and closing call on a server call closed by custom interceptor #50933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2025
Merged

gRPC: Avoid repeatedly starting call and closing call on a server call closed by custom interceptor #50933

merged 1 commit into from
Nov 12, 2025

Conversation

@michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Nov 7, 2025

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Nov 7, 2025
@michalvavrik
Copy link
Member Author

michalvavrik commented Nov 7, 2025 •
edited
Loading

I'll leave someone responsible for gRPC area to decide if this should be backported in case it is acceptable in some form.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 7, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8d93d7f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

cescoffier
cescoffier approved these changes Nov 9, 2025
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for @alesj

@gsmet gsmet merged commit 4224d5f into quarkusio:main Nov 12, 2025
44 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.30 - main milestone Nov 12, 2025
@michalvavrik michalvavrik deleted the feature/fix-grpc-interceptor-closing branch November 12, 2025 10:08
@gsmet gsmet modified the milestones: 3.30.0.CR1, 3.29.3 Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cescoffier cescoffier cescoffier approved these changes

+1 more reviewer

@alesj alesj alesj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/grpc gRPC kind/bugfix triage/backport-3.27

Projects

None yet

Milestone

3.29.3

Development

Successfully merging this pull request may close these issues.

Closing in gRPC interceptor causes double close in Vert.x gRPC implementation

4 participants

@michalvavrik @alesj @cescoffier @gsmet