Do not fix load in a test intended to measure throughput #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz1981
approved these changes
Nov 3, 2025
franz1981
left a comment
franz1981
left a comment
There was a problem hiding this comment.
It's fine but you can reduce the number of connections too depending what is the actual connection pool size of agroal/postgres.
In any case it is fine 🙏
holly-cummins
force-pushed
the
fix-perf-scripts
branch
from
3456872 to
6222dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I know this conflicts with #18 which has been open for ages, but I spotted that I'd made a copy-paste error in the original scripts, and the stress test script was actually a latency-test script.