Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

Clarify formatDate i18n usage #634

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

webnoob
Copy link
Contributor

@webnoob webnoob commented Nov 8, 2018

Update to add clarity to how formatDate handles i18n. The third parameter only needs to be used when using your own custom i18n instance. Quasar will handle it's own internal one and set the locale when it changes.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • [ x] Provided documentation update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [ x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ x] It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all major browsers

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Update to add clarity to how formatDate handles i18n. The third parameter only needs to be used when using your own custom i18n instance. Quasar will handle it's own internal one and set the locale when it changes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant