-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat: Add resizing for QTable Columns: Issue #5115 #17838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Can I get a review on this please? |
You mixed
This change would also require to add the description of the added things in the API description JSON If you want a review on code please change the PR so that it matches the existing code. |
I'll work on that thank you for the feedback :) |
- double clicking resizer brings column back to their default size
hey @pdanpdan sorry to ask but could you tell me where the api description json is? So far i cleaned up most of what you wanted and added ability to use column definitions to specify which columns are resizable. Also made it so you can double click the grabbers to make the columns go back to their default size. Still need to clean up code a bit and add the description of the new functionality to the api description json. |
-documented new feature in QTable.json
Hello. Any news on this ? Looking forward to see it integrated |
Hi. I'm looking forward too. @pdanpdan do you have any updates? |
I would like this feature too, but it's clearly not good enough yet to be reviewed. I did a little cleanup in my own branch here that you can review. timbze@2553817 One rule of PRs for good code is not to change any existing code that is not related to your PR. Your PR changes a lot of spacing, adding semi-colons etc. I know it's probably your IDE or AI that did it, but still you need to review it and not submit anything that is not related to your changes. One of the reasons why I know this won't be accepted yet is the manual 150 width that you add on mount. I don't have enough time to figure out how to do it correctly but IMHO this is clearly not it. Likely you should not add |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
dev
branch (orv[X]
branch)fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
I am excited to submit this pull request, which introduces a feature that has been highly requested by the community, including myself. This is my first contribution to the project, and I have designed the component to be highly customizable to accommodate various use cases.
I welcome any feedback or suggestions for improvements, and I am open to making any necessary adjustments to ensure it aligns with the project's standards and goals.
Thank you for considering my contribution!
// Example Photos from test app used to verify functionality
Example table with one resizable column:
