Skip to content

Conversation

chrisjung-dev
Copy link

@chrisjung-dev chrisjung-dev commented Jun 27, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

The ...attrs property in the <q-drawer> Component is filtered to allow actual behaviour but route aria-label and aria-labelledby to the aside element to make this compent usable in a WCAG comforming way.

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:
As per https://www.w3.org/WAI/WCAG22/Understanding/bypass-blocks, landmarks with implicit complementary roles should route attributes for <q-drawer> related to naming to the generated <aside> element

@chrisjung-dev chrisjung-dev changed the title fix: route aria-label* attributes to aside element (fix #18058) fix(QDrawer): route aria-label* attributes to aside element (fix #18058) Jul 3, 2025
@chrisjung-dev
Copy link
Author

Any feedback on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants