aii-ks: Only wait for 120 seconds in wait_for_network#360
Merged
wpoely86 merged 1 commit intoquattor:mainfrom Jan 14, 2026
Merged
aii-ks: Only wait for 120 seconds in wait_for_network#360wpoely86 merged 1 commit intoquattor:mainfrom
wpoely86 merged 1 commit intoquattor:mainfrom
Conversation
The previous code assumed that nslookup failed instantly, however the default behaviour makes three requests, each with a timeout of 5 seconds, so a host with completely broken networking will take 120 * (15 + 1) seconds (32 minutes) to error out.
jrha
force-pushed
the
fix_wait_for_network
branch
from
987f888 to
333e0d7
Compare
wpoely86
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code assumed that
nslookupfailed instantly, however the default behaviour makes three requests, each with a timeout of 5 seconds, so a host with completely broken networking will take120 * (15 + 1)seconds (32 minutes) to error out.Fixes #354.