Skip to content

panlint: Add support for suppressing checks on specific lines#278

Merged
wpoely86 merged 1 commit intoquattor:mainfrom
jrha:suppression_original
Jan 28, 2026
Merged

panlint: Add support for suppressing checks on specific lines#278
wpoely86 merged 1 commit intoquattor:mainfrom
jrha:suppression_original

Conversation

@jrha
Copy link
Member

@jrha jrha commented Jan 6, 2026 •
edited
Loading

Use "disable" as keyword for suppressing checks following pylint's example
Add test file for check suppression

@jrha jrha added the panlint label Jan 6, 2026
@jrha jrha force-pushed the suppression_original branch from dcba51b to c493f1f Compare January 8, 2026 17:34
@jrha jrha added this to the 10.9 milestone Jan 8, 2026
@jrha jrha force-pushed the suppression_original branch 2 times, most recently from 836b53f to 2911d5e Compare January 14, 2026 11:20
@jrha jrha marked this pull request as ready for review January 14, 2026 11:21
@jrha jrha changed the title Check Suppression panlint: Add support for supressing checks on specific lines Jan 14, 2026
@jrha jrha changed the title panlint: Add support for supressing checks on specific lines panlint: Add support for suppressing checks on specific lines Jan 14, 2026
@jrha jrha force-pushed the suppression_original branch from 2911d5e to 2532610 Compare January 14, 2026 11:22
This was referenced Jan 14, 2026
Open
Draft
ned21
ned21 reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

@ned21 ned21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if this is a stupid question and I've missed something (it's late on a Friday) but doesn't there need to be a change to tests.py to consume the test pan file?

Also, how do I see the coverage report that GH actions generates? I can download the load but the coverage isn't in the log. It would be nice to see that the new lines are actually covered.

I was thinking that making sure line 608 is definitely covered would be an important test!

@jrha
Copy link
Member Author

jrha commented Jan 17, 2026

Yeah, it's not that obvious, but there's a bit of magic in the test suite that tests all pan files in that directory.

I'm not sure GitHub keeps the coverage reports, I'll have a closer look next week.

@jrha
Copy link
Member Author

jrha commented Jan 20, 2026

I've opened #282 to fix coverage reporting, if that gets merged first I'll rebase this PR.

@jrha
panlint: Add support for suppressing checks on specific lines
c698957 
Use "disable" as keyword for suppressing checks following pylint's example
Add test file for check suppression
@jrha jrha force-pushed the suppression_original branch from 2532610 to c698957 Compare January 26, 2026 10:42
@jrha
Copy link
Member Author

jrha commented Jan 26, 2026

Rebased on main to pull in the coverage output to the workflow.

@jrha jrha requested a review from ned21 January 26, 2026 10:44
@wpoely86 wpoely86 merged commit 7b012ac into quattor:main Jan 28, 2026
2 checks passed
@jrha jrha deleted the suppression_original branch January 30, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

@ned21 ned21 Awaiting requested review from ned21

Assignees

No one assigned

Labels

panlint

Milestone

10.9

Development

Successfully merging this pull request may close these issues.

3 participants

@jrha @ned21 @wpoely86