panlint: store results of union

[wpoely86]

The code was not working

[ned21]

Can we have some more detail in the commit message please? I am particularly curious as to why this wasn't caught by the unit tests? Can we add one to check correct behaviour?

[wpoely86]

Can we have some more detail in the commit message please? I am particularly curious as to why this wasn't caught by the unit tests? Can we add one to check correct behaviour?

Where should these tests run? 🙃

[wpoely86]

Nevermind, found it.

There is no tests that uses that code. It directly tests with the subfunction.

[jrha]

For readability I'd prefer:

components_included.update(ignore_components)

or:

components_included = components_included.union(ignore_components)

[wpoely86]

I'm not a big fan of that. It's very verbose.

[jrha]

Whoops, we should add at least a test_good_component.pan in panc/src/main/scripts/panlint/test_files/.

[ned21]

Code is fine (I think, I defer to James). But the documentation (aka commit logs) could be improved :)

panlint: fix import
Not clear to me what is being "fixed" here, or rather what was broken. Can you describe what problem you observed to which this is the fix?

Also I think it would be efficient to merge the other 2 commits into 1 with a nice explanation.