Allow the caf_service_action to be used by multiple components #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdweird
reviewed
Oct 25, 2018
stdweird
reviewed
Oct 31, 2018
jrha
force-pushed
the
move_caf_service_action
branch
from
15718b9 to
3cfc1f2
Compare
This is essentially the same as the caf_service_action type from ncm-metaconfig but redefined to allow for extensions.
jrha
force-pushed
the
move_caf_service_action
branch
from
3cfc1f2 to
e30e8f1
Compare
Member
stdweird
reviewed
Nov 1, 2018
|
|
||
| include 'quattor/functions/validation'; | ||
|
|
||
| type caf_service_actions = string with choice( |
Member
There was a problem hiding this comment.
i'm going to come back on my own remark:
reintroduce the caf_service_action type (and remove ti from metaconfig)
and also introduce the following
type caf_service_actions = {
daemons ? caf_service_action{}
};that way we can add support by simply including this type in the schema, rather than copy pasting it everywhere
Member
Author
|
Closed, see discussion in quattor/configuration-modules-core#1335. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be reverted during the release process unless the corresponding change is made to ncm-metaconfig in configuration-modules-core.