refactor: simplify if-clause

questionpy-org · Jul 29, 2024 · 68633ef · 68633ef
1 parent abce26a
commit 68633ef
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/classes/question_ui_renderer.php b/classes/question_ui_renderer.php
@@ -130,9 +130,10 @@ private function hide_unwanted_feedback(): void {
             $feedback = $element->getAttributeNS(constants::NAMESPACE_QPY, "feedback");
 
             if (
-                !in_array($feedback, ["general", "specific"])
-                || ($feedback == "general" && !$this->options->generalfeedback)
-                || ($feedback == "specific" && !$this->options->feedback)
+                !(
+                    ($feedback == "general" && $this->options->generalfeedback)
+                    || ($feedback == "specific" && $this->options->feedback)
+                )
             ) {
                 $element->parentNode->removeChild($element);
             }