feat: favourite package UI #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbritz
requested review from
MartinGauk,
MHajoha,
larsbonczek and
alexanderschmitz
larsbonczek
requested changes
Feb 29, 2024
Comment on lines
+87
to
+89
| $usercontext = context_user::instance($USER->id); | ||
| $ufservice = \core_favourites\service_factory::get_service_for_user_context($usercontext); | ||
| $packagearray['isfavourite'] = $ufservice->favourite_exists('qtype_questionpy', 'package', $package->id, $usercontext); |
There was a problem hiding this comment.
Vielleicht wäre es sinnvoll, den Code zum Abrufen und Ändern des favourite-Status in die Package Klasse zu verschieben. Oder in eine eigene Helper-Klasse. Du benutzt den ja sowohl hier als auch in dem Webservice.
larsbonczek
approved these changes
Mar 11, 2024
janbritz
force-pushed
the
feat/favourite-package-ui
branch
from
ee4ab73
to
f82b2ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100.
Ein Paket kann nun über die UI (ent-)favorisiert werden. Der 'Favourites'-Tab updatet hierbei simultan.
Das Icon und der Text vom Favorisieren-Button updaten sich in allen Tabs, in denen das Paket zu finden ist.
Ein Paket kann, auch nachdem es ausgewählt wurde, (ent-)favorisiert werden.
