#119: Statische Dateien ausliefern #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHajoha
force-pushed
the
static-files
branch
2 times, most recently
from
c001ef2
to
41e4507
Compare
janbritz
approved these changes
Aug 20, 2024
janbritz
requested changes
Aug 20, 2024
MartinGauk
requested changes
Aug 30, 2024
MHajoha
force-pushed
the
static-files
branch
from
41e4507
to
934fc6a
Compare
MartinGauk
approved these changes
Sep 9, 2024
janbritz
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ich hatte mir ursprünglich in den Kopf gesetzt, den ganzen Pfad von
file_pluginfilebis inkl.send_filezu testen. Nach viel Zeitverschwendung bin ich aber zu dem Schluss gekommen, dass das nicht geht. U.a. geht Moodle davon aus, dassqtype_questionpy_pluginfilebei Erfolg immerdied, das lässt sich auch für Tests nicht unterbinden. Undsend_filemacht alle Level von Output Buffering aus.Zwei neue Dinge, die hier hinzukommen, sind die Nutzung des HTTP-Clients Guzzle und Moodle's Wrapper dafür, und Dependency Injection via https://moodledev.io/docs/4.4/apis/core/di. Den Rest des API-Codes sollten wir demnächst ™️ dann auch auf Guzzle umbiegen.
Aktuell scheitern die Actions beim Versuch, moodle-plugin-ci zu installieren. Das schaue ich mir morgen mal an, passiert aber auch auf dev.