Merge pull request #766 from ChoiJunsik/improve-remove-section-function

update removeSection method to remove sections with the same property key and value
quickfix-j · Feb 21, 2024 · fd1926f · fd1926f
2 parents 663fb55 + 7d16ec4
commit fd1926f
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/quickfixj-core/src/main/java/quickfix/SessionSettings.java b/quickfixj-core/src/main/java/quickfix/SessionSettings.java
@@ -887,12 +887,13 @@ public void removeSection(final SessionID sessionID) throws ConfigError {
     }
 
     public void removeSection(final String propertyKey, final String propertyValue) throws ConfigError {
-        SessionID sessionIdToRemove = sections.entrySet().stream()
+        List<SessionID> sessionIDs = sections.entrySet().stream()
                 .filter(entry -> propertyValue.equals(entry.getValue().get(propertyKey)))
                 .map(Map.Entry::getKey)
-                .findFirst()
-                .orElseThrow(() -> new ConfigError("Session not found"));
+                .collect(Collectors.toList());
 
-        sections.remove(sessionIdToRemove);
+        for (SessionID sessionID : sessionIDs) {
+            this.removeSection(sessionID);
+        }
     }
 }