Fix stuck call to Dial when calling Stop on the Initiator #654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue when calling Start() and then Stop() on the initiator while the connection is likely to fail and timeout. Sending a SIGTERM and calling Stop() will block since Dial will attempt to connect until it times out and returns on the
waitForReconnectInterval
call.We mitigate this problem by using a
proxy.ContextDialer
and allowing to pass a context with cancellation method to thedialer.DialContext
method onhandleConnection
.We need to start a routine listening for the
stopChan
in order to call cancel() explicitly and thus exit the DialContext method.Note: there are scenarios where
cancel()
will be called twice, this choice was made in order to avoid a larger refactor of the reconnect logic, but since the call tocancel()
is idempotent, this doesn't lead to any adverse effect.fixes #653