-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garbage collect shards in SQS Filesource #5339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
a2ffa08
to
34dce73
Compare
784bb16
to
89d09bd
Compare
ce78565
to
66c1ca8
Compare
89d09bd
to
b680d1e
Compare
There is one footgun here that I would like to avoid: it might happen that a shard is garbage collected right before it's published (e.g
|
7c543ee
to
d1885af
Compare
fulmicoton
reviewed
Sep 17, 2024
quickwit/quickwit-indexing/src/source/queue_sources/shared_state.rs
Outdated
Show resolved
Hide resolved
fulmicoton
reviewed
Sep 17, 2024
fulmicoton
reviewed
Sep 17, 2024
quickwit/quickwit-indexing/src/source/queue_sources/shared_state.rs
Outdated
Show resolved
Hide resolved
fulmicoton
reviewed
Sep 17, 2024
quickwit/quickwit-indexing/src/source/queue_sources/shared_state.rs
Outdated
Show resolved
Hide resolved
fulmicoton
reviewed
Sep 17, 2024
quickwit/quickwit-indexing/src/source/queue_sources/shared_state.rs
Outdated
Show resolved
Hide resolved
fulmicoton
reviewed
Sep 17, 2024
quickwit/quickwit-indexing/src/source/queue_sources/shared_state.rs
Outdated
Show resolved
Hide resolved
fulmicoton
reviewed
Sep 17, 2024
quickwit/quickwit-indexing/src/source/queue_sources/shared_state.rs
Outdated
Show resolved
Hide resolved
fulmicoton
reviewed
Sep 17, 2024
fulmicoton
reviewed
Sep 17, 2024
fulmicoton
reviewed
Sep 17, 2024
1bace04
to
c98bfd6
Compare
fulmicoton
reviewed
Sep 18, 2024
quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/shards.rs
Outdated
Show resolved
Hide resolved
fulmicoton
reviewed
Sep 18, 2024
fulmicoton
reviewed
Sep 18, 2024
fulmicoton
approved these changes
Sep 18, 2024
fulmicoton
approved these changes
Sep 19, 2024
fulmicoton
approved these changes
Sep 19, 2024
fbb8916
to
a600c3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trigger the prune_shards endpoint from the SQS file sources.
How was this PR tested?
Added integration test.