Skip to content

Reduce delete index concurrency to 5 #5346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2024
Merged

Reduce delete index concurrency to 5 #5346

merged 2 commits into from
Aug 26, 2024

Conversation

guilload
Copy link
Member

Description

Reduce delete index concurrency to 5 and deserialize splits outside the Tokio runtime.

How was this PR tested?

make test-all

@guilload guilload requested a review from fulmicoton August 26, 2024 12:55
@github-actions GitHub Actions
Copy link

On SSD:

Average search latency is 1.0x that of the reference (lower is better).
Ref run id: 2983, ref commit: 7bed022
Link

On GCS:

Average search latency is 1.04x that of the reference (lower is better).
Ref run id: 2984, ref commit: 7bed022
Link

@guilload guilload merged commit e3927eb into main Aug 26, 2024
5 checks passed
@guilload guilload deleted the guilload/reduce-delete-index-concurrency branch August 26, 2024 14:34
@fulmicoton fulmicoton mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trinity-1686a trinity-1686a trinity-1686a approved these changes

@fulmicoton fulmicoton Awaiting requested review from fulmicoton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilload @trinity-1686a