Disable control plane check for searcher. #5360
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd get rid of the env var. We never need the control plane check for searchers anyway. |
fmassot
force-pushed
the
fmassot/searcher-can-start-with-no-control-plane
branch
from
9127acf to
dcb5305
Compare
fmassot
changed the title
| if !node_config.is_service_enabled(QuickwitService::Metastore) { | ||
| // If the node is a searcher, we skip this check because the searcher does not need to. | ||
| if !(node_config.is_service_enabled(QuickwitService::Metastore) | ||
| || node_config.is_service_enabled(QuickwitService::Searcher)) |
There was a problem hiding this comment.
I think this is wrong: unless i'm missing something it's telling "if metastore is disabled AND searcher is disabled", connect to control plane. This means if this node is searcher+indexer, don't connect to the metastore
What we want is if !(is_service_enabled(Metastore) OR enabled_services.filter(service != Searcher).is_empty)
There was a problem hiding this comment.
I agree with @trinity-1686a . (except I believe the expression can simply be
enabled_services.filter(service != Searcher).is_empty() (as it includes the metastore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.