Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve trace search backward compatibility #5371

Merged
merged 1 commit into from
Aug 30, 2024
Merged

improve trace search backward compatibility #5371

merged 1 commit into from
Aug 30, 2024

Conversation

trinity-1686a
Copy link
Contributor

@trinity-1686a trinity-1686a commented Aug 30, 2024 •
edited
Loading

Description

fix #5367
before, querying trace-v0_7 would fail. Now both trace-v0_7 and trace-v0_9 works (though the improvement in #5358 is only available for v0_9)

How was this PR tested?

tested on grafana ui

@github-actions GitHub Actions
Copy link

On SSD:

Average search latency is 0.999x that of the reference (lower is better).
Ref run id: 3143, ref commit: d684b92
Link

On GCS:

Average search latency is 0.913x that of the reference (lower is better).
Ref run id: 3145, ref commit: d684b92
Link

@trinity-1686a trinity-1686a merged commit ab1a782 into main Aug 30, 2024
5 checks passed
@trinity-1686a trinity-1686a deleted the trinity/improve-trace-backward-compat branch August 30, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

@fulmicoton fulmicoton Awaiting requested review from fulmicoton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

follow up to #5358
2 participants
@trinity-1686a @fmassot