-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch delete from gc #5404
batch delete from gc #5404
Conversation
sql.join( | ||
JoinType::Join, | ||
Indexes::Table, | ||
Expr::col((Splits::Table, Splits::IndexUid)) | ||
.equals((Indexes::Table, Indexes::IndexUid)), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: i think this is a bad idea to do this long term, but i'd rather this fix be made without a migration for now, so we can easily revert clusters affected to previous versions if we find things are somehow still not good. If you disagree, we can either create the required index manually, or make a migration
Description
follow up to #5380
if a cluster generate less than 1k split per 10 minutes, everything was fine, but in case it would generate more than that, we have a slow down for 2 reasons:
Changes made:
How was this PR tested?
tested on a small cluster to not be utterly broken, for perf improvement, we'll need a way bigger cluster