Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process in-flight merges upon shutting down indexing pipelines #5473

Closed
wants to merge 1 commit into from

Conversation

guilload
Copy link
Member

@guilload guilload commented Oct 3, 2024

Description

Per title.

How was this PR tested?

In progress. Tests are passing, but I'm testing various scenarios locally (REST ingest, CLI ingest, etc.)

Copy link

github-actions bot commented Oct 3, 2024

On SSD:

Average search latency is 0.991x that of the reference (lower is better).
Ref run id: 3700, ref commit: 2dcc696
Link

On GCS:

Average search latency is 1.03x that of the reference (lower is better).
Ref run id: 3701, ref commit: 2dcc696
Link

@guilload
Copy link
Member Author

guilload commented Oct 4, 2024

Closing in favor of #5475.

@guilload guilload closed this Oct 4, 2024
@guilload guilload deleted the guilload/finalize-merges branch October 4, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant