4829 minimum should match #5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
4829-minimum-should-match
branch
4 times, most recently
from
b7a4984
to
d1f0dce
Compare
fulmicoton
force-pushed
the
4829-minimum-should-match
branch
from
d1f0dce
to
d7a2c5b
Compare
Fixing rest compatilibility tests. Closes #4828
fulmicoton
force-pushed
the
4829-minimum-should-match
branch
from
d7a2c5b
to
ba35e9c
Compare
| must_not, | ||
| }) | ||
| }) | ||
| let minimum_should_match = (0usize..2).prop_map(|n: usize| n.checked_sub(1)); |
There was a problem hiding this comment.
if we generate some minimum_should_match, evaluate_test must be updated to to consider it. Otherwise we don't verify it on the generated nor simplified request, so the test tests nothing
There was a problem hiding this comment.
updated the evaluate_test... and found a bug! thx
quickwit/rest-api-tests/scenarii/es_compatibility/_setup.quickwit.yaml
Outdated
Show resolved
Hide resolved
fulmicoton
force-pushed
the
4829-minimum-should-match
branch
2 times, most recently
from
f634b98
to
0bb5f22
Compare
fulmicoton
force-pushed
the
4829-minimum-should-match
branch
from
0bb5f22
to
a835f4f
Compare
fulmicoton
force-pushed
the
4829-minimum-should-match
branch
from
a835f4f
to
da577fd
Compare
trinity-1686a
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for minimum_should_match
https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-minimum-should-match.html
Fixing rest compatilibility tests.
Closes #4828