don't enumerate index_uid when requesting splits to gc #5489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Oct 15, 2024
fulmicoton
reviewed
Oct 15, 2024
fulmicoton
force-pushed
the
trinity/gc-no-index_uid-in
branch
from
873d64d
to
a98ec47
Compare
fulmicoton
force-pushed
the
trinity/gc-no-index_uid-in
branch
from
a98ec47
to
5b63045
Compare
fulmicoton
approved these changes
Oct 15, 2024
no-op refactoring.
fulmicoton
force-pushed
the
trinity/gc-no-index_uid-in
branch
from
5b63045
to
c1cf01d
Compare
trinity-1686a
commented
Oct 15, 2024
Comment on lines
365
to
368
| if let Some(splits) = splits_metadata_to_delete_per_index.get_mut(&meta.index_uid) { | ||
| splits.push(meta); | ||
| } else { | ||
| splits_metadata_to_delete_per_index.insert(meta.index_uid.clone(), vec![meta]); |
There was a problem hiding this comment.
this can be expressed with the entry api, which imo is easier to read
There was a problem hiding this comment.
Yeah. I was avoiding the needless 10k allocation, but yeah, maybe it does not matter. I will switch to the entry API.
| .into_group_map(); | ||
| for meta in splits_metadata_to_delete { | ||
| if !storages.contains_key(&meta.index_uid) { | ||
| info!(index_uid=?meta.index_uid, "split not listed in storage map: skipping"); |
There was a problem hiding this comment.
this won't log often, but when it does, it may log a lot. this should be rate-limited
trinity-1686a
commented
Oct 17, 2024
fulmicoton
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.