Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow specifying otel index id in header #5503

Merged
merged 1 commit into from
Oct 18, 2024
Merged

allow specifying otel index id in header #5503

merged 1 commit into from
Oct 18, 2024

Conversation

trinity-1686a
Copy link
Contributor

Description

allow providing index id through header instead of path params in otel http-grpc api
fix #5413
follow up to #5421

@github-actions GitHub Actions
Copy link

On SSD:

Average search latency is 0.993x that of the reference (lower is better).
Ref run id: 3898, ref commit: 6b4acd0
Link

On GCS:

Average search latency is 1.14x that of the reference (lower is better).
Ref run id: 3899, ref commit: 6b4acd0
Link

@trinity-1686a trinity-1686a merged commit 29338a8 into main Oct 18, 2024
5 checks passed
@trinity-1686a trinity-1686a deleted the trinity/otel-header-indexid branch October 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilload guilload guilload approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not specify an index id on the http otel api
2 participants
@trinity-1686a @guilload