Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unit conversion in jaeger http search endpoint #5519

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix unit conversion in jaeger http search endpoint #5519

merged 1 commit into from
Oct 23, 2024

Conversation

trinity-1686a
Copy link
Contributor

Description

fix #5511

How was this PR tested?

completed unit tests

@github-actions GitHub Actions
Copy link

On SSD:

Average search latency is 1.01x that of the reference (lower is better).
Ref run id: 3998, ref commit: b045483
Link

On GCS:

Average search latency is 1.03x that of the reference (lower is better).
Ref run id: 3999, ref commit: b045483
Link

@guilload guilload merged commit 3a1532a into main Oct 23, 2024
5 checks passed
@guilload guilload deleted the trinity/jaeger-http-duration branch October 23, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilload guilload guilload approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

using quickwit-searcher as jaeger datasource with grafana, duration field parse incorrectly
2 participants
@trinity-1686a @guilload