Parse datetimes and timestamps with leading and/or trailing whitespace #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinity-1686a
approved these changes
Nov 6, 2024
|
That makes sense. Let me add a commit on top of this PR. |
fulmicoton
reviewed
Nov 7, 2024
| @@ -36,22 +36,24 @@ pub fn parse_date_time_str( | |||
| date_time_str: &str, | |||
| date_time_formats: &[DateTimeInputFormat], | |||
| ) -> Result<TantivyDateTime, String> { | |||
| let trimmed_date_time_str = date_time_str.trim(); | |||
There was a problem hiding this comment.
Suggested change
| let trimmed_date_time_str = date_time_str.trim(); | |
| let trimmed_date_time_str = date_time_str.trim_ascii(); |
There was a problem hiding this comment.
It is probably minor, but triming unicode is considerably more expensive than trimming ascii.
(It requires decoding utf-8, and check if each individual char is a whitespace or not. )
I'd feel safer if we restricted ourselves to ascii. It will just prevent us from trimming weird whitespace like the japanese " ".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per title. Request by Airmail. Supported by ES.
How was this PR tested?
make test-all