Open
Conversation
The property `quic.stream.length` that the tool uses doesn't seem to be emitted by wireshark for frames that carry no explicit length information (stream frame is at the end of the packet). In that case the generated qlog will not have a length field. To fix this, we calculate the length based on the data in the frame (which is correctly emitted). Fixes quiclog#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property
quic.stream.lengththat the tool uses doesn't seem to be emittedby wireshark for frames that carry no explicit length information (stream frame is
at the end of the packet). In that case the generated qlog will not have a length field.
To fix this, we calculate the length based on the data in the frame (which is correctly
emitted).
Fixes #7