Filter files uploaded for supported ones#44
Open
hawkinsw wants to merge 1 commit intoquiclog:masterfrom
hawkinsw:filtered_file_upload
Open
Filter files uploaded for supported ones#44hawkinsw wants to merge 1 commit intoquiclog:masterfrom hawkinsw:filtered_file_upload
hawkinsw wants to merge 1 commit intoquiclog:masterfrom
hawkinsw:filtered_file_upload
Conversation
The current behavior of qvis is to reject all files uploaded together when one of them cannot be accepted because of an invalid filename. This patch modifies that behavior so that only those files that do not have an acceptable file extension are rejected and the others are properly parsed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior of qvis is to reject all files uploaded
together when one of them cannot be accepted because of an
invalid filename.
This patch modifies that behavior so that only those files
that do not have an acceptable file extension are rejected
and the others are properly parsed.