Open
Conversation
Member
|
Thanks Marten. I do have a docker setup for qvis, but it's in this separate repo, as it also contains ways to setup the server-side things needed for loading pcaps / bypassing CORS stuff. If you're just running the frontend it's indeed pretty straightforward. I'll keep this PR in mind for the new version for people that indeed just want a quick way to run the frontend. |
Contributor
Author
|
This PR was not intended to replace your current setup, but just as a way to easily run qvis locally. Any reason to not just merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easy to run qvis locally when the hosted qvis happens to be offline.
You could also consider publishing a Docker image on Dockerhub / on the GitHub Docker registry. Should be pretty straightforward to publish a build for every push to master. Let me know if you'd be interested in a follow-up PR.
docker build . -t qvis docker run -p 8080:8080 qvis