Add NextJS app to start rebuild #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfranklin11
force-pushed
the
add-next-ui
branch
2 times, most recently
from
955e45a to
e6f563e
Compare
cfranklin11
force-pushed
the
add-next-ui
branch
6 times, most recently
from
ae46f99 to
f19ed2b
Compare
meligatt
reviewed
Sep 10, 2024
| @@ -37,8 +37,8 @@ services: | |||
| - "8080:8080" | |||
| environment: | |||
| COCKROACH_DATABASE: ${DB_NAME} | |||
| AWS_ACCESS_KEY_ID: ${AWS_ACCESS_KEY_ID} | |||
| AWS_SECRET_ACCESS_KEY: ${AWS_SECRET_ACCESS_KEY} | |||
| AWS_ACCESS_KEY_ID: ${AWS_ACCESS_KEY_ID:-""} | |||
There was a problem hiding this comment.
@cfranklin11 Could you please explain the purpose of the colon and dash in that variable? I haven't encountered something like that before.
AWS_ACCESS_KEY_ID:-""
meligatt
approved these changes
Sep 10, 2024
meligatt
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're rebuilding the app with a simpler architecture using NextJS. The plan is to migrate the
clientandserver(except for the admin section) services to this new app, then deploy it some PaaS (probably Vercel, but still TBD). This gets us started with the initial app setup and installation of basic dependencies for running the app and testing.We decided on NextUI for the component library, because it makes for an easier migration than just TailwindCSS, but works better with NextJS's current architecture (server components) than component libraries based on JS-in-CSS packages, which is most of them.